Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iox-#75 Update links and author information #76

Merged
merged 5 commits into from
Apr 22, 2024
Merged

iox-#75 Update links and author information #76

merged 5 commits into from
Apr 22, 2024

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Apr 22, 2024 •
edited
Loading

Pre-Review Checklist for the PR Author

  1. Code follows the Rust coding style and is formatted with rustfmt
  2. Branch follows the naming format (iox-123-this-is-a-branch)
  3. Commits messages are according to this guideline
  4. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  5. Relevant issues are linked
  6. Add sensible notes for the reviewer
  7. All checks have passed (except task-list-completed)
  8. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido requested a review from elfenpiff April 22, 2024 14:40
@elBoberido elBoberido self-assigned this Apr 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.37%. Comparing base (fdd6495) to head (afade8b).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   49.83%   50.37%   +0.54%     
==========================================
  Files          20       18       -2     
  Lines        1202     1195       -7     
==========================================
+ Hits          599      602       +3     
+ Misses        603      593      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elBoberido elBoberido merged commit 61f740c into main Apr 22, 2024
10 of 12 checks passed
@elBoberido elBoberido deleted the iox-75-update-links-and-author-information branch April 22, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elfenpiff elfenpiff elfenpiff approved these changes

Assignees

@elBoberido elBoberido

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update links and author information
3 participants
@elBoberido @codecov-commenter @elfenpiff